From 2ac8c9c4c3a75b5e20f7fae4416885814b07a5fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Fra=C3=9F?= Date: Sat, 1 Jun 2024 13:49:11 +0200 Subject: [PATCH 1/2] [fix] role:ufw:add missing become:true directives [mod] role:ufw:use fully qualified names for ansible tasks --- roles/ufw/tasks/main.json | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/roles/ufw/tasks/main.json b/roles/ufw/tasks/main.json index b3ed847..003e4b6 100644 --- a/roles/ufw/tasks/main.json +++ b/roles/ufw/tasks/main.json @@ -11,7 +11,8 @@ }, { "name": "ufw deny incoming", - "ufw": { + "become": true, + "community.general.ufw": { "direction": "incoming", "proto": "any", "policy": "deny" @@ -19,7 +20,8 @@ }, { "name": "ufw allow outgoing", - "ufw": { + "become": true, + "community.general.ufw": { "direction": "outgoing", "proto": "any", "policy": "allow" @@ -27,14 +29,16 @@ }, { "name": "ufw allow and rate-limit ssh", - "ufw": { + "become": true, + "community.general.ufw": { "rule": "limit", "name": "ssh" } }, { "name": "enable ufw service", - "ufw": { + "become": true, + "community.general.ufw": { "state": "enabled" } } From c7c9e6895cd6df181707e023434b485967ed375b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Fra=C3=9F?= Date: Sat, 1 Jun 2024 17:56:28 +0200 Subject: [PATCH 2/2] [fix] roles with ufw incocation --- roles/lighttpd/tasks/main.json | 23 +++++++++++++---------- roles/murmur/tasks/main.json | 18 ++++++++++-------- roles/nginx/tasks/main.json | 23 +++++++++++++---------- roles/proftpd/tasks/main.json | 23 +++++++++++++---------- roles/synapse/tasks/main.json | 16 +++++++++------- 5 files changed, 58 insertions(+), 45 deletions(-) diff --git a/roles/lighttpd/tasks/main.json b/roles/lighttpd/tasks/main.json index 8e85d43..d29fcdf 100644 --- a/roles/lighttpd/tasks/main.json +++ b/roles/lighttpd/tasks/main.json @@ -28,30 +28,33 @@ } }, { - "name": "Check wether enabling UFW would be considered a changed", + "name": "ufw | check", "check_mode": true, + "become": true, "community.general.ufw": { - "state": "enabled", - "register": "ufw_enable_check" - } + "state": "enabled" + }, + "register": "ufw_enable_check" }, { - "name": "Allow port 80 in ufw", + "name": "ufw | allow port 80", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "80", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { - "name": "Allow port 443 in ufw", + "name": "ufw | allow port 443", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "443", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { "name": "restart service", diff --git a/roles/murmur/tasks/main.json b/roles/murmur/tasks/main.json index b8303b2..1b9ed12 100644 --- a/roles/murmur/tasks/main.json +++ b/roles/murmur/tasks/main.json @@ -26,21 +26,23 @@ } }, { - "name": "Check wether enabling UFW would be considered a changed", + "name": "ufw | check", "check_mode": true, + "become": true, "community.general.ufw": { - "state": "enabled", - "register": "ufw_enable_check" - } + "state": "enabled" + }, + "register": "ufw_enable_check" }, { - "name": "Allow port in ufw", + "name": "ufw | allow port", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", - "port": "{{ var_murmur_port }}", + "port": "{{var_murmur_port | string}}", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { "name": "service", diff --git a/roles/nginx/tasks/main.json b/roles/nginx/tasks/main.json index 39a68de..2fe467c 100644 --- a/roles/nginx/tasks/main.json +++ b/roles/nginx/tasks/main.json @@ -10,30 +10,33 @@ } }, { - "name": "Check wether enabling UFW would be considered a changed", + "name": "ufw | check", + "become": true, "check_mode": true, "community.general.ufw": { - "state": "enabled", - "register": "ufw_enable_check" - } + "state": "enabled" + }, + "register": "ufw_enable_check" }, { - "name": "Allow port 80 in ufw", + "name": "ufw | allow port 80", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "80", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { - "name": "Allow port 443 in ufw", + "name": "ufw | allow port 443", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "443", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { "name": "restart service", diff --git a/roles/proftpd/tasks/main.json b/roles/proftpd/tasks/main.json index 53374a6..e5bf9a0 100644 --- a/roles/proftpd/tasks/main.json +++ b/roles/proftpd/tasks/main.json @@ -10,29 +10,32 @@ } }, { - "name": "Check wether enabling UFW would be considered a changed", + "name": "ufw | check", "check_mode": true, + "become": true, "community.general.ufw": { - "state": "enabled", - "register": "ufw_enable_check" - } + "state": "enabled" + }, + "register": "ufw_enable_check" }, { - "name": "Allow FTP port 20 in ufw", + "name": "ufw | allow port 20", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "20", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { - "name": "Allow FTP port 21 in ufw", + "name": "ufw | allow port 21", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "21", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } } ] diff --git a/roles/synapse/tasks/main.json b/roles/synapse/tasks/main.json index ef5c79c..63e0e78 100644 --- a/roles/synapse/tasks/main.json +++ b/roles/synapse/tasks/main.json @@ -59,21 +59,23 @@ } }, { - "name": "Check wether enabling UFW would be considered a changed", + "name": "ufw | check", + "become": true, "check_mode": true, "community.general.ufw": { - "state": "enabled", - "register": "ufw_enable_check" - } + "state": "enabled" + }, + "register": "ufw_enable_check" }, { - "name": "Allow matrix federation port in ufw", + "name": "ufw | allow port", + "when": "not ufw_enable_check.changed", + "become": true, "community.general.ufw": { "rule": "allow", "port": "8448", "proto": "tcp" - }, - "when": "not ufw_enable_check.changed" + } }, { "name": "restart service",