From 389b171401bbef40b021e74e8c9249f172d2ca8b Mon Sep 17 00:00:00 2001
From: Marius Melzer <marius@rasumi.net>
Date: Wed, 24 Apr 2024 20:02:51 +0200
Subject: [PATCH] Apply review comments

---
 roles/system-basics/tasks/main.json       |  9 ++++
 roles/unattended-upgrades/tasks/main.json | 62 +++++++++++------------
 2 files changed, 40 insertions(+), 31 deletions(-)

diff --git a/roles/system-basics/tasks/main.json b/roles/system-basics/tasks/main.json
index 707b1f1..08c35fe 100644
--- a/roles/system-basics/tasks/main.json
+++ b/roles/system-basics/tasks/main.json
@@ -14,6 +14,15 @@
 		},
 		"notify": "restart journal"
 	},
+	{
+		"name": "Install vim",
+		"become": true,
+		"ansible.builtin.apt": {
+			"pkg": [
+				"vim"
+			]
+		}
+	},
 	{
 		"name": "Set vim as default editor",
 		"community.general.alternatives": {
diff --git a/roles/unattended-upgrades/tasks/main.json b/roles/unattended-upgrades/tasks/main.json
index 7706bc3..4098ae9 100644
--- a/roles/unattended-upgrades/tasks/main.json
+++ b/roles/unattended-upgrades/tasks/main.json
@@ -1,33 +1,33 @@
 [
-  {
-    "name": "Allow unattended reboots (1)",
-    "lineinfile": {
-      "dest": "/etc/apt/apt.conf.d/50unattended-upgrades",
-      "regexp": "^(//)?Unattended-Upgrade::Automatic-Reboot ",
-      "line": "Unattended-Upgrade::Automatic-Reboot \"true\";"
-    }
-  },
-  {
-    "name": "Allow unattended reboots (2)",
-    "lineinfile": {
-      "dest": "/etc/apt/apt.conf.d/50unattended-upgrades",
-      "regexp": "^(//)?Unattended-Upgrade::Automatic-Reboot-Time ",
-      "line": "Unattended-Upgrade::Automatic-Reboot-Time \"23:55\";"
-    }
-  },
-  {
-    "name": "Allow more origins for updates",
-    "lineinfile": {
-      "dest": "/etc/apt/apt.conf.d/50unattended-upgrades",
-      "regexp": "^(//\\s*)?\"\\$\\{distro_id\\}:\\$\\{distro_codename\\}-updates\";",
-      "line": "\"${distro_id}:${distro_codename}-updates\";"
-    }
-  },
-  {
-    "name": "Enable unattended upgrades",
-    "copy": {
-      "src": "20auto-upgrades",
-      "dest": "/etc/apt/apt.conf.d/20auto-upgrades"
-    }
-  }
+	{
+		"name": "Allow unattended reboots (1)",
+		"lineinfile": {
+			"dest": "/etc/apt/apt.conf.d/50unattended-upgrades",
+			"regexp": "^(//)?Unattended-Upgrade::Automatic-Reboot ",
+			"line": "Unattended-Upgrade::Automatic-Reboot \"true\";"
+		}
+	},
+	{
+		"name": "Allow unattended reboots (2)",
+		"lineinfile": {
+			"dest": "/etc/apt/apt.conf.d/50unattended-upgrades",
+			"regexp": "^(//)?Unattended-Upgrade::Automatic-Reboot-Time ",
+			"line": "Unattended-Upgrade::Automatic-Reboot-Time \"23:55\";"
+		}
+	},
+	{
+		"name": "Allow more origins for updates",
+		"lineinfile": {
+			"dest": "/etc/apt/apt.conf.d/50unattended-upgrades",
+			"regexp": "^(//\\s*)?\"\\$\\{distro_id\\}:\\$\\{distro_codename\\}-updates\";",
+			"line": "\"${distro_id}:${distro_codename}-updates\";"
+		}
+	},
+	{
+		"name": "Enable unattended upgrades",
+		"copy": {
+			"src": "20auto-upgrades",
+			"dest": "/etc/apt/apt.conf.d/20auto-upgrades"
+		}
+	}
 ]